fix(lib/es2015): Move Promise.race(Iterable) to es2015.iterable.d.ts - #36435
Closed
ExE Boss (ExE-Boss) wants to merge 2 commits into
Closed
fix(lib/es2015): Move Promise.race(Iterable) to es2015.iterable.d.ts#36435ExE Boss (ExE-Boss) wants to merge 2 commits into
Promise.race(Iterable) to es2015.iterable.d.ts#36435ExE Boss (ExE-Boss) wants to merge 2 commits into
Conversation
ExE Boss (ExE-Boss)
requested review from
Daniel Rosenwasser (DanielRosenwasser) and
Ryan Cavanaugh (RyanCavanaugh)
January 25, 2020 19:01
Contributor
|
See #36368 |
Nathan Shively-Sanders (sandersn)
added
the
For Milestone Bug
Contributor
|
Note that this PR has the following unapproved change: - all<TAll>(values: Iterable<TAll | PromiseLike<TAll>>): Promise<TAll[]>;
+ all<T>(values: Iterable<T>): Promise<(T extends PromiseLike<infer U> ? U : T)[]>;#36368 is the conservative original PR. |
ExE Boss (ExE-Boss)
requested a review
from Nathan Shively-Sanders (sandersn)
February 1, 2020 10:41
Nathan Shively-Sanders (sandersn)
added
For Backlog Bug
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#31117 caused an issue where the
Promise.raceoverload that takes anIterableargument was ines2015.promise.d.tsinstead of being ines2015.iterable.d.ts.Fixes #31722
Supersedes and closes #36368